This repository has been archived by the owner on Sep 15, 2020. It is now read-only.
[BUGFIX] Destroying an opened popover removes all attached listeners #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyril-sf
force-pushed
the
cyril/memory-leak
branch
from
14c43bd
to
0efc75c
Compare
|
@cyril-sf I think CI here wants attention. |
|
@mixonic I know, I'm looking at it. |
cyril-sf
changed the title
cyril-sf
force-pushed
the
cyril/memory-leak
branch
from
a265edf
to
f98c526
Compare
NicholasMohr
approved these changes
Nov 14, 2019
|
Changes here look fine though I've asked for some work on #67 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
_popperKeyHandlerevent handler is added when the popover opens and is removed when it closes.However, it's possible to destroy the component before closing the popover, leading to a memory leak. This PR simply makes sure that all event handlers are removed in
willDestroyElement.Need #67 to be merged first to fix the build.