Skip to content

Commit

Permalink
[DOCS] Show selected-row checkmark
Browse files Browse the repository at this point in the history
Fixes #593

The underlying styles that we import from '@addepar/style-toolbox/onyx/index'
should be modified so that they don't hardcode an absolute URL for the background-image
checkmark svg, but in lieu of that larger-scope fix, this PR copies the checkmark.svg
asset and adds a singular style override to display it.
  • Loading branch information
bantic committed Jul 17, 2019
1 parent 74d858f commit 697b942
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 0 deletions.
11 changes: 11 additions & 0 deletions tests/dummy/app/styles/app.scss
Original file line number Diff line number Diff line change
@@ -1,6 +1,17 @@
@import './tables';
@import '@addepar/style-toolbox/onyx/index';

// Override the url for the checkmark that indicates row selection.
// This overrides a style in style-toolbox that uses the absolute url
// '/@addepar/style-toolbox/assets/images/checkmark.svg'. When addon docs
// are deployed, the root URL is '/ember-table/', and thus the checkmark asset
// is not able to be loaded.
// So instead we override the style and use a checkmark svg that has been added to this project:
// See https://github.com/Addepar/ember-table/issues/593
.ember-table .et-toggle-select input[type='checkbox'] + *:after {
background-image: url('images/checkmark.svg');
}

$colors: (
navy: #001f3f,
blue: #0074d9,
Expand Down
1 change: 1 addition & 0 deletions tests/dummy/public/assets/images/checkmark.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 697b942

Please sign in to comment.