Skip to content

Commit

Permalink
Pin Node 14, try vertical-collection 3 (#921)
Browse files Browse the repository at this point in the history
Node 14 should be a minumum supported version for the Ember Table 4
series. Additionally, try vertical-collection 3 which should bring support for
Ember 4.
  • Loading branch information
mixonic authored and kpfefferle committed Dec 10, 2021
1 parent 0999935 commit d979a10
Show file tree
Hide file tree
Showing 3 changed files with 272 additions and 25 deletions.
12 changes: 6 additions & 6 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,17 +6,17 @@ on:
jobs:
test:
name: Run Tests
runs-on: ubuntu-18.04
runs-on: ubuntu-latest
timeout-minutes: 6

steps:
- name: Checkout
uses: actions/checkout@v2

- name: Use Node 12
- name: Use Node 14
uses: actions/setup-node@v2-beta
with:
node-version: 12.x
node-version: 14.x

- name: Node Modules Cache
uses: actions/cache@v2
Expand All @@ -37,7 +37,7 @@ jobs:

test-ember-try:
name: Run Tests
runs-on: ubuntu-18.04
runs-on: ubuntu-latest
timeout-minutes: 6

strategy:
Expand All @@ -61,10 +61,10 @@ jobs:
- name: Checkout
uses: actions/checkout@v2

- name: Use Node 12
- name: Use Node 14
uses: actions/setup-node@v2-beta
with:
node-version: 12.x
node-version: 14.x

- name: Node Modules Cache
uses: actions/cache@v2
Expand Down
8 changes: 4 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"@babel/plugin-proposal-object-rest-spread": "^7.12.13",
"@babel/plugin-proposal-optional-catch-binding": "^7.12.13",
"@babel/plugin-proposal-optional-chaining": "^7.12.13",
"@html-next/vertical-collection": "^2.0.0",
"@html-next/vertical-collection": "3.0.0-0",
"broccoli-string-replace": "^0.1.2",
"css-element-queries": "^0.4.0",
"ember-classy-page-object": "^0.7.0",
Expand Down Expand Up @@ -92,7 +92,7 @@
"sass": "^1.26.10"
},
"engines": {
"node": ">= 10.*"
"node": ">= 14.*"
},
"ember-addon": {
"configPath": "tests/dummy/config"
Expand All @@ -102,7 +102,7 @@
"prettier": "1.18.2"
},
"volta": {
"node": "12.22.3",
"yarn": "1.22.10"
"node": "14.18.2",
"yarn": "1.22.17"
}
}
Loading

0 comments on commit d979a10

Please sign in to comment.