Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow fillMode to to support placing the width delta in the nth column #634

Closed
chbonser opened this issue Nov 26, 2018 · 2 comments
Closed

Allow fillMode to to support placing the width delta in the nth column #634

chbonser opened this issue Nov 26, 2018 · 2 comments

Comments

@chbonser
Copy link
Contributor

Currently the fillMode prop supports 3 options, equal-column, first-column, last-column. https://opensource.addepar.com/ember-table/latest/docs/guides/header/size-constraints#fill-mode

I'm proposing adding a nth-column option with a supporting fillColumnIndex prop. This will allow placing the width delta in a middle column.

I'll submit a PR soon with a working implementation.
@chbonser chbonser mentioned this issue Nov 26, 2018
Merged
@hleimig
Copy link

hleimig commented Mar 21, 2019

+1

@cyril-sf
Copy link
Contributor

cyril-sf commented Aug 1, 2019

Fixed with #635

@cyril-sf cyril-sf closed this as completed Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cyril-sf @chbonser @hleimig