enable fillMode to support an nth-column option #635
Conversation
|
@chbonser sorry for the delay. It seems like a good option. Could you update your PR now that we don't use ES classes and decorators? It would be a good thing to refactor the code so that |
|
@cyril-sf Yes. I can make those changes. It will be a few weeks though... |
|
@chbonser no problem and thanks for the help! |
|
would love to see this merged in. I could possibly help out getting this across the finish line if you still don't have the bandwidth to work on it @chbonser ? |
|
Sorry for the delay. I will make time for it next week.
…On Tue, Jul 9, 2019 at 2:02 PM Bill Dami ***@***.***> wrote:
would love to see this merged in. I could possibly help out getting this
across the finish line if you still don't have the bandwidth to work on it
@chbonser <https://github.com/chbonser> ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#635?email_source=notifications&email_token=AAHZU5TH66C6JUKSKDJPCHLP6THEFA5CNFSM4GGMWWS2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZRBQTI#issuecomment-509745229>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAHZU5UUJXFSLVHOMHHWJODP6THEFANCNFSM4GGMWWSQ>
.
|
chbonser
force-pushed
the
nth-col-fill-mode
branch
from
a97cdc6 to
3861c1e
Compare
|
@cyril-sf I've rebased and updated the fill mode implementation to reuse the resize implementation across all single column fill modes. The behavior of the preexisting modes remains unchanged so this is a non-breaking addition. |
|
|
||
| @argument fillMode | ||
| @type string? ('equal-column') | ||
| */ | ||
| fillMode: defaultTo(FILL_MODE.EQUAL_COLUMN), | ||
|
|
||
| /** | ||
| A configuration that controls how which column shinks (or extends) when `fillMode` is |
There was a problem hiding this comment.
| A configuration that controls how which column shinks (or extends) when `fillMode` is | |
| A configuration that controls which column shrinks (or extends) when `fillMode` is |
| /** | ||
| A configuration that controls how which column shinks (or extends) when `fillMode` is | ||
| 'nth-column'. This is zero indexed. | ||
| */ |
There was a problem hiding this comment.
For the autogenerated API docs can you add:
@argument fillColumnIndex
@type number?
|
@chbonser no need to apologize, we appreciate the extra effort! |
|
released in |
#634