Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An old version of ember-test-selectors is busting deprecation workflow: getWithDefault #846

Open
NullVoxPopuli opened this issue Jan 7, 2021 · 6 comments

Comments

@NullVoxPopuli
Copy link
Contributor

This is resolved in v5: https://github.com/simplabs/ember-test-selectors/blob/master/CHANGELOG.md

@NullVoxPopuli NullVoxPopuli changed the title An old version of ember-test-selectors is busting depercation workflow: getWithDefault An old version of ember-test-selectors is busting deprecation workflow: getWithDefault Jan 7, 2021
@mixonic
Copy link
Member

mixonic commented Feb 6, 2021

@NullVoxPopuli What does "busting deprecation workflow" mean?

@NullVoxPopuli
Copy link
Contributor Author

I should have added more details. oof.
My guess is either:
Emmer-cli-dendency-checker error or the deprecations hadn't yet been updated to the new format? (Deprecation staging stuff?)

@NullVoxPopuli
Copy link
Contributor Author

ok, now that I've seen this again, I can confirm:

folks using throwOnUnhandled: true must silence getWithDefault deprecations, because ember-table uses and old version of ember-test-selectors

@BobrImperator
Copy link

Seems like this could wait until 2.8 drop as per #884 (comment). or even longer actually, until it's decided to drop below 3.8 support - judging by provided changelog.

@NullVoxPopuli
Copy link
Contributor Author

NullVoxPopuli commented Mar 24, 2021

@BobrImperator, we are using ember-table version 3.0.2-1

@BobrImperator
Copy link

BobrImperator commented Mar 24, 2021

Still looks like EmberTable 3.0 intents to drop support for Ember <2.8, while ember-test-selectors 5.0 require Ember 3.8+ if i'm not mistaken. So until maintainers decide to drop versions below 3.8, we might have to live with the deprecation.

Please bear in mind, I'm not a maintainer, was just skimming through issues :D

References:
https://github.com/simplabs/ember-test-selectors/blob/master/CHANGELOG.md
https://github.com/Addepar/ember-table/releases/tag/v3.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants