Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade ember-test-selectors to get around the getWithDefault deprecation #847

Conversation

NullVoxPopuli
Copy link
Contributor

See: #846

@NullVoxPopuli NullVoxPopuli force-pushed the update-ember-test-selectors branch from 3da90f6 to 406c3d1 Compare January 7, 2021 16:43
@mixonic
Copy link
Member

mixonic commented Feb 2, 2021

@NullVoxPopuli can you rebase? I'd like to sanity check this against Addepar's internal usage but it seems reasonable.

@NullVoxPopuli
Copy link
Contributor Author

Rebased!

@mixonic mixonic force-pushed the update-ember-test-selectors branch from 490de2b to cea76fb Compare February 3, 2021 17:41
@mixonic
Copy link
Member

mixonic commented Feb 3, 2021

This was rebased onto 3.0.0-3 or something. I rebased it onto the 3.0-beta branch which is what it targets and pushed.

@mixonic mixonic force-pushed the update-ember-test-selectors branch from cea76fb to 02b1f77 Compare February 3, 2021 18:29
@mixonic mixonic mentioned this pull request Feb 5, 2021
@mixonic mixonic force-pushed the update-ember-test-selectors branch from 02b1f77 to 6743ff8 Compare February 5, 2021 19:57
@mixonic
Copy link
Member

mixonic commented Feb 6, 2021

@NullVoxPopuli per the changelog in https://github.com/simplabs/ember-test-selectors/blob/master/CHANGELOG.md, v2 of ember-test-selectors is the last version to support Ember versions before 2.16. As this library must support Ember 2.8 (or Addepar won't really be able to us it), we can't bump the version of the test selector dependency past 2.x at this time.

@mixonic mixonic closed this Feb 6, 2021
@NullVoxPopuli
Copy link
Contributor Author

Maybe we release another v2 version that addresses the deprecation?

@mixonic
Copy link
Member

mixonic commented Feb 6, 2021

@NullVoxPopuli Yeah honestly getWithDefault is very easy to avoid. It would be fairly straightforward to write the patch upgrading ember-test-selector 2.x if the maintainers are willing to accept it.

I will say that ember-table is not going to be able to drop support for 2.x (even 2.8) for a good while. I would plan for 6 months of Ember 2.8 support and a year of Ember 2.x support as a rough, very rough, estimation. I hope that context helps you figure out next steps for your own contributions/efforts.

@NullVoxPopuli
Copy link
Contributor Author

It does, thanks! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants