-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use bower; add versioning and release process #148
Conversation
* Removes dist folder * Uses release-it for automating release process
Great work!
|
Does bower install run as part of the default grunt task? |
@@ -3,7 +3,6 @@ | |||
// ----------------------------------------------------------------------------- | |||
|
|||
@import 'mixins'; | |||
@import '../../dependencies/antiscroll/antiscroll'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check whether this needs to be kept
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yayalice so the reason this is gone is that antiscroll is now a dependency, and ember-table users will have to include it in their projects. For example, the demo app now has https://github.com/azirbel/ember-table/blob/bowerify/app/index.html#L13. It seems that in the past ember-table came with antiscroll.css included right in the ember-table.css file. Think this change makes sense?
Thanks @petrvolny and @yayalice! I got rid of lockdown and grunt-browserify2 and added grunt-bower-task to install dependencies when grunt is run. |
Won't be migrating to the dist repo for now - I'm not convinced it's a good move yet. New PR (easier to review) is here: #157 |
…ll-flags Add group row control flags.
Resolves #78 and #98. This PR definitely needs review, since I'm no expert with bower or grunt. Feedback is much appreciated! @danjamin, @yayalice, or @bigsley might be able to help.
What this does:
No dist folder? How to develop and integration test?
To be resolved: