Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bower; add versioning and release process #148

Closed
wants to merge 13 commits into from

Conversation

azirbel
Copy link
Contributor

@azirbel azirbel commented Apr 28, 2014

Resolves #78 and #98. This PR definitely needs review, since I'm no expert with bower or grunt. Feedback is much appreciated! @danjamin, @yayalice, or @bigsley might be able to help.

What this does:

  • Move many dependencies to bower
  • Remove dist folder
  • Set up process to release to this repo and a shim repo for dist files
  • Use grunt-text-replace and release-it to bump version numbers

No dist folder? How to develop and integration test?

  • The dist folder is not in version control (hooray, fewer steps to PR!), but it's still generated by grunt.
  • Use "bower link" and "bower link ember-table" when developing ember-table and testing with your app.

To be resolved:

  • Need to figure out where the shim repo will be - could be in https://github.com/components, or a new Addepar repo.
  • Need to transition bower to use the new shim repo without disrupting everyone's build

Alex Zirbel added 3 commits April 28, 2014 12:27
 * Removes dist folder
 * Uses release-it for automating release process
@petrvolny
Copy link
Contributor

Great work!
My 2 cents:

  • I think we can get rid of all the lockdown.json stuff now since we use bower for deps.
  • I also noticed that we have grunt-browserify2 in Gruntfile.js which is not used anywhere in the repo so I suggest to remove it.

@yayalice
Copy link

yayalice commented May 8, 2014

Does bower install run as part of the default grunt task?

@@ -3,7 +3,6 @@
// -----------------------------------------------------------------------------

@import 'mixins';
@import '../../dependencies/antiscroll/antiscroll';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check whether this needs to be kept

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yayalice so the reason this is gone is that antiscroll is now a dependency, and ember-table users will have to include it in their projects. For example, the demo app now has https://github.com/azirbel/ember-table/blob/bowerify/app/index.html#L13. It seems that in the past ember-table came with antiscroll.css included right in the ember-table.css file. Think this change makes sense?

@azirbel
Copy link
Contributor Author

azirbel commented May 12, 2014

Thanks @petrvolny and @yayalice! I got rid of lockdown and grunt-browserify2 and added grunt-bower-task to install dependencies when grunt is run.

@azirbel azirbel mentioned this pull request May 19, 2014
@azirbel
Copy link
Contributor Author

azirbel commented May 19, 2014

Won't be migrating to the dist repo for now - I'm not convinced it's a good move yet. New PR (easier to review) is here: #157

@azirbel azirbel closed this May 19, 2014
@azirbel azirbel deleted the bowerify branch August 20, 2014 02:53
Gaurav0 pushed a commit to Gaurav0/ember-table that referenced this pull request Nov 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Ember table shim should be automated on release
3 participants