Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Columns reorder fix, Ember 1.8.1 changed removeObject (Issue #243) #262

Closed
wants to merge 1 commit into from
Closed

Conversation

edelsbrunner
Copy link

Ember 1.8.1 is firing some methods from new Morph library when calling removeObject, and this was removing the columns from DOM, causing a null problem.

The problem is described here: #243

Using Jquery grep remove only the column to reorder, and prevent this from happening

@azirbel
Copy link
Contributor

azirbel commented Jan 22, 2015

Hi @mariuserik and thanks for bringing this to our attention (and for your fix)!

@ebryn took a look; another description of the underlying problem is that jQuery sortable and ember both want to manipulate the DOM. His solution is to cancel jQuery so Ember can do its thing: #265. I think we'll go with this approach, which should still fix your issue. Let us know if you have any objection!

@azirbel azirbel closed this Jan 22, 2015
@edelsbrunner
Copy link
Author

Awesome, LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants