Add column resizing & footer to Page Objects in test #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billy-addepar
force-pushed
the
billy/test-support-drag-column
branch
from
e138462 to
9513c07
Compare
|
@Addepar/ice |
pzuraq
reviewed
Dec 12, 2017
addon/components/ember-table.js
Outdated
| @@ -175,8 +175,10 @@ export default class EmberTable2 extends Component { | |||
| }); | |||
|
|
|||
| this._tableResizeSensor = new ResizeSensor(this.element, () => { | |||
There was a problem hiding this comment.
This seems like it should be a separate PR/bugfix. Also, we should try to use ember-resize-sensor soon, that's what we built it for after all
pzuraq
approved these changes
Dec 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.