chore(deps): Update legacy shim and @argument #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pzuraq
force-pushed
the
pzuraq/chore/update-deps
branch
from
1f0f657 to
31288a8
Compare
twokul
approved these changes
Feb 5, 2018
| @@ -30,7 +30,7 @@ export default class EmberTableFooter extends EmberTableBaseCell { | |||
| } | |||
|
|
|||
| @action | |||
| onFooterEvent() { | |||
| sendFooterEvent() { | |||
| this.sendAction('onFooterEvent', ...arguments); | |||
There was a problem hiding this comment.
Do you want to update this name too for consistency?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some recent research we've been able to make the legacy class transforms and
@argumentmore efficient overall, and more inline with the future version of ES classes. This PR bumps the dependencies to the most recent releases.