[refactor] Use position: sticky; for fixed headers/footers/columns #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| export function teardownStickyPolyfill(component) { | ||
| component.element.removeEventListener('scroll', component._repositionHandler); |
There was a problem hiding this comment.
You might want to detach all resize sensors in the teardown.
addon/components/ember-table.js
Outdated
| super.willDestroyElement(...arguments); | ||
| } | ||
|
|
||
| getChildElement(tagName) { |
|
🎉 With this the table automatically supports text wrapping 😄 |
This PR switches us to a rendering strategy using position: sticky; in all modern browsers. This is much more performant and simpler in the code, and maintains semantic table structure - everything we've been after! For IE11, the only browser we support which does not support sticky, we use a rudimentary polyfill. The polyfill is not comprehensive, it only solves our exact use case by using `translateX/Y` on scroll.
pzuraq
force-pushed
the
pzuraq/new-table-css
branch
from
4752ef4 to
f9dbff6
Compare
billy-addepar
approved these changes
Apr 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches us to a rendering strategy using position: sticky;
in all modern browsers. This is much more performant and simpler in the
code, and maintains semantic table structure - everything we've been
after!
For IE11, the only browser we support which does not support sticky, we
use a rudimentary polyfill. The polyfill is not comprehensive, it only
solves our exact use case by using
translateX/Yon scroll.