Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[restructure] Simplify and flatten caching #513

Merged

Conversation

pzuraq
Copy link
Contributor

@pzuraq pzuraq commented Apr 24, 2018

This is some of the precursor work to the new API:

  1. Simplify the cell cache in general
  2. Wrap columns and rows in proxies that add meta properties
  3. Yield value cell column row as described in the new API
  4. Have CollapseTree return the list of parents, which allows us to
    correctly figure out selection state in tree tables (more work and tests
    on that coming in future PRs)
  5. Create a "row wrapper" component. This is necessary for wrapping the
    rows in proxy objects, since it should be done after VC has done its
    work in order to remain stable, but before we yield to the tr because
    we don't want to complicate the tr logic (its been a struggling
    point on the refactor branch)

This is some of the precursor work to the new API:

1. Simplify the cell cache in general
2. Wrap columns and rows in proxies that add `meta` properties
3. Yield `value cell column row` as described in the new API
4. Have CollapseTree return the list of parents, which allows us to
correctly figure out selection state in tree tables (more work and tests
on that coming in future PRs)
5. Create a "row wrapper" component. This is necessary for wrapping the
rows in proxy objects, since it should be done _after_ VC has done its
work in order to remain stable, but before we yield to the `tr` because
we don't want to complicate the `tr` logic (its been a struggling
point on the refactor branch)
@pzuraq pzuraq force-pushed the pzuraq/restructure/simplify-and-generalize-cell-cache branch from c3c0000 to 5b63cbc Compare April 24, 2018 20:13
@pzuraq pzuraq merged commit 2ebfb25 into master Apr 24, 2018
@pzuraq pzuraq deleted the pzuraq/restructure/simplify-and-generalize-cell-cache branch April 24, 2018 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant