Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Avoid clickable elements when toggling row selection #538

Merged
merged 1 commit into from
May 23, 2018

Conversation

pzuraq
Copy link
Contributor

@pzuraq pzuraq commented May 23, 2018

Currently, users will have to manually handle events in their usage of
Ember Table when clicking a button or other interactable element to
prevent row selection from toggling. This PR causes the table to ignore
any clicks that originate in a clickable element (button, label,
input, a, or select for nows).

Currently, users will have to manually handle events in their usage of
Ember Table when clicking a button or other interactable element to
prevent row selection from toggling. This PR causes the table to ignore
any clicks that originate in a clickable element (`button`, `label`,
`input`, `a`, or `select` for nows).
@pzuraq pzuraq merged commit 954d420 into master May 23, 2018
@pzuraq pzuraq deleted the bugfix/prevent-row-click-on-inputs branch May 23, 2018 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant