[bugfix] Fix Column Sorting #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was possible for columns to get into a bad state based on the ordering of Hammer event handlers and the click event handler. This PR fixes it temporarily, but I think this needs further refactoring. Testing this currently would be very difficult (it would require a lot of intricate ordering of events) so this PR does not add tests. Locking us into a series of events that will likely be refactored seems ill-advised.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was possible for columns to get into a bad state based on the
ordering of Hammer event handlers and the click event handler. This PR
fixes it temporarily, but I think this needs further refactoring.
Testing this currently would be very difficult (it would require a lot
of intricate ordering of events) so this PR does not add tests. Locking
us into a series of events that will likely be refactored seems
ill-advised.
Fixes #553