use window scroll position for ember-router-scroll #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm noticing now that ember-cli-addon-docs actually includes ember-router-scroll as a direct dependency now. Perhaps its docs are out of date and we don't need to install it directly, only to make sure that it is configured? Gonna try that out to see if it was really just a problem due to bad config. |
This configures the ember-router-scroll addon to properly remember scroll position between routes. This is installed as part of ember-cli-addon-docs, but its config in the dummy app here pointed to an element that doesn't exist. Instead I just removed the config and it now uses the `window` scroll position instead, which works well.
bgentry
force-pushed
the
ember-router-scroll-in-docs
branch
from
3555204 to
416f2f3
Compare
bgentry
changed the title
|
I updated the PR to merely fix the config for ember-router-scroll, which appears to work. Also opened a corresponding issue to fix the docs at ember-learn/ember-cli-addon-docs#203. |
|
Thanks for the fix! Was wondering why that was happening |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the addon docs, I was getting annoyed that the documentation app did not scroll-to-top when clicking to a different docs section. This fixes that.
In the ember-cli-addon-docs quickstart, they mention ember-router-scroll as an optional dependency to tackle this problem.
This installs the ember-router-scroll addon to properly remember scroll position between routes, and to reset it when the route changes. There was already a (copy-pasted?) config for this in the dummy app, but it pointed to an element that doesn't exist. Instead I just removed the config and it now uses the
windowscroll position instead, which works well.