[bugfix] Only clean caches on table destroy #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, whenever rows change we attempt to erase the row meta values for rows which are no longer part of the table. This is an O(n) operation which is fairly expensive, and we were doing it wrong as we were not traversing children rows at all. This PR moves the cache cleaning to only occur when the table is fully destroyed. This means that we may hold onto meta objects longer than is ideal, but we also won't incur an expensive operation every time the table is updated. The alternative would be to fix the cache cleaning so that we traverse child rows as well.
pzuraq
force-pushed
the
pzuraq/bugfix/only-clean-cache-on-table-destroy
branch
from
7545b76 to
e0bf5cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, whenever rows change we attempt to erase the row meta values
for rows which are no longer part of the table. This is an O(n)
operation which is fairly expensive, and we were doing it wrong as we
were not traversing children rows at all.
This PR moves the cache cleaning to only occur when the table is fully
destroyed. This means that we may hold onto meta objects longer than is
ideal, but we also won't incur an expensive operation every time the
table is updated. The alternative would be to fix the cache cleaning so
that we traverse child rows as well.