Pass through 'idForFirstItem' to the vertical-collection, so scroll-position can be restored #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll provide a test for this feature. |
|
@pzuraq do you have some concerns? |
|
Sorry, I haven't had time to review recently. This looks good, the code just needs a rebase and it'll be ready to merge. |
…, so there's a possibility to restore scroll-position
wuarmin
force-pushed
the
restore_scroll_position
branch
from
32cfb1a to
35dc6b2
Compare
|
@pzuraq @addepar-andy Sorry for the delay. I rebased it. Thank you and kind regards |
|
Looks like tests are failing on beta because of the new changes to native classes, I don't have time to dig in just yet unfortunately but will try to find some soon. @twokul would you be alright with merging this even with tests failing? Should be fine up to Ember 3.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to achieve a restoring of the scroll-position. WDYT?
Best regards