Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Fix how selection works when selecting rows not yet inserted in the DOM #626

Closed
wants to merge 7 commits into from

Conversation

gwak
Copy link

@gwak gwak commented Oct 3, 2018

Because of how vertical-collection works, the TableRowMetaCache is only populated for a given row when inserted into the DOM, when vertical-collection invokes objectAt(index) function of tree node.
We thus need to setup non-existent meta cache from selected rows.

@gwak gwak changed the title Fix how selection works when selecting rows not yet inserted in the DOM [bugfix] Fix how selection works when selecting rows not yet inserted in the DOM Oct 3, 2018
@tempo22
Copy link

tempo22 commented Oct 11, 2018

I can confirm this fix this issue for me aswell

Copy link

@sanmaverick sanmaverick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested these changes and they work well.

@ghost
Copy link

ghost commented Nov 2, 2018

@gwak the package-lock.json changes here should be removed. Quick tip is to just git checkout master package-lock.json.

@ghost
Copy link

ghost commented Nov 2, 2018

I've verified this fixes a bug in our application as well. Thank you @gwak !

@gwak
Copy link
Author

gwak commented Nov 5, 2018

@gwak the package-lock.json changes here should be removed. Quick tip is to just git checkout master package-lock.json.

@efx I've just removed the package-lock.json

@ghost
Copy link

ghost commented Dec 14, 2018

@gwak are you able to update this PR with master and see what the error is? Once that is done we can try to get this merged into master.

@ghost
Copy link

ghost commented Dec 19, 2018

Additionally, a unit or integration test should be included to assert the change.

@mixonic
Copy link
Member

mixonic commented Jul 9, 2019

@gwak yeah I'm also very interested in learning how this manifests in usage.

@bantic
Copy link
Contributor

bantic commented Jul 19, 2019

This should be fixed by #727, which has been released in 2.0.0-beta.9.
@gwak When possible, can you try beta 9 and see if it fixes the issue for you?
I'm going to close this now as I believe #727 fully covers this, but please reopen if I'm mistaken.

@bantic bantic closed this Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants