-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bugfix] Fix how selection works when selecting rows not yet inserted in the DOM #626
Conversation
I can confirm this fix this issue for me aswell |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested these changes and they work well.
@gwak the |
I've verified this fixes a bug in our application as well. Thank you @gwak ! |
@gwak are you able to update this PR with master and see what the error is? Once that is done we can try to get this merged into master. |
Additionally, a unit or integration test should be included to assert the change. |
@gwak yeah I'm also very interested in learning how this manifests in usage. |
Because of how vertical-collection works, the TableRowMetaCache is only populated for a given row when inserted into the DOM, when vertical-collection invokes
objectAt(index)
function of tree node.We thus need to setup non-existent meta cache from selected rows.