Cleaner Gruntfile, Added JSDoc, Building standalone vanilla lib (without deps) and many more .. #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: lib/ember-table.js
…anges From https://github.com/gemfury/ember-table/ Conflicts: lib/ember-table.js lib/ember-table.min.js
… dependencies and files are concatenated in correct order
This was referenced Aug 18, 2013
Closed
Conflicts: package.json
|
@korczis I tried running this PR and ran into the following Chrome error: Assertion failed: You specified the templateName tables-container for Ember.Table.TablesContainer:ember241, but it did not exist. |
|
I will check it and update the PR, sorry for troubles caused. |
|
Should be fine now. Can we merge it now? |
…jsdoc-in-coffee Conflicts: package.json
Conflicts: package.json
Conflicts: package.json
This was referenced Aug 25, 2013
Closed
|
@korczis thanks for the pr! Looks good :) |
ppong
pushed a commit
that referenced
this pull request
Aug 27, 2013
Cleaner Gruntfile, Added JSDoc, Building standalone vanilla lib (without deps) and many more ..
|
Thank YOU for merging this in. |
Gaurav0
pushed a commit
to Gaurav0/ember-table
that referenced
this pull request
Oct 13, 2015
Regular and command sort
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, let me mention, that output of refactored grunt remains the same as original.
Intermediate build files are .gitgnored.
Using few more grunt tasks
New grunt tasks configured
Last but not least, Grunt was rewritten from coffee to js.
Next steps eliminate remaining ad-hoc compiled templates and use only handlerbars-runtime