Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Use sortEmptyLast on the header to have empty values at the end of a sort result. #673

Merged
merged 1 commit into from
Apr 1, 2019
Merged

[FEATURE] Use sortEmptyLast on the header to have empty values at the end of a sort result. #673

merged 1 commit into from
Apr 1, 2019

Conversation

cyril-sf
Copy link
Contributor

@cyril-sf cyril-sf commented Mar 29, 2019 •
edited
Loading 

<EmberThead @sortEmptyLast=true />

This is the default implementation (sortEmptyLast=false):

Screen Shot 2019-03-19 at 1 56 49 PM

with sortEmptyLast=true, the sort returns the meaningful values first

This will allow to choose how to sort values like that:
Screen Shot 2019-03-19 at 1 56 41 PM

mixonic
mixonic approved these changes Apr 1, 2019
View reviewed changes
Copy link
Member

@mixonic mixonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! Excellent addition @cyril-sf :-D

[FEATURE] Use sortEmptyLast on the header to have empty values at t…
772e67a 
…he end of a sort result.

```
<EmberThead @sortEmptyLast=true />
```
@cyril-sf cyril-sf merged commit f2825fd into master Apr 1, 2019
@cyril-sf cyril-sf deleted the cyril/null-sort branch April 1, 2019 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mixonic mixonic mixonic approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cyril-sf @mixonic