Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Add "Testing" section #717

Merged
merged 1 commit into from
Jul 15, 2019
Merged

[DOCS] Add "Testing" section #717

merged 1 commit into from
Jul 15, 2019

Conversation

bantic
Copy link
Contributor

@bantic bantic commented Jul 15, 2019

fixes #715

Add addon-test-support/index.js to export the TablePage from a central
location.

Upgrade @addepar/eslint-config to ^4.0.2 so that the index.js is linted
correctly.

Add a "Testing" section to the addon docs that describes basic usage of the
TablePage.

The addon docs page looks like this:
image

Add `addon-test-support/index.js` to export the TablePage from a central
location.

Upgrade @addepar/eslint-config to ^4.0.2 so that the `index.js` is linted
correctly.

Add a "Testing" section to the addon docs that describes basic usage of the
TablePage.
@bantic bantic requested a review from twokul July 15, 2019 17:47
@bantic bantic added this to the Prepare for 2.0 release milestone Jul 15, 2019
@bantic bantic added the docs label Jul 15, 2019
@@ -27,6 +27,11 @@
{{nav.item 'Rows and Trees' 'docs.guides.body.rows-and-trees'}}
{{nav.item 'Row Selection' 'docs.guides.body.row-selection'}}
{{nav.item 'Occlusion' 'docs.guides.body.occlusion'}}

{{nav.section 'Testing'}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this on the live site? Or tests/dummy/ is only content for test?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what generates the "Testing" section in the addon docs. (The tests/dummy app is the addon docs.)

Copy link
Member

@mixonic mixonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had misread this entirely. Looks great!

@bantic bantic merged commit 5c6f61e into master Jul 15, 2019
@delete-merged-branch delete-merged-branch bot deleted the bantic/docs/test-page-object branch July 15, 2019 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

DOCS: Document the table test page object
2 participants