Tweak Sass styles #832
Merged
Tweak Sass styles #832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After we have updated `ember-cli-sass` to `10`, the following warnings started popping up: ```sh WARNING: You probably don't mean to use the color value silver in interpolation here. It may end up represented as silver, which will likely produce invalid CSS. Always quote color names when using them as strings or map keys (for example, "silver"). If you really want to use the color value here, use '"" + $color-name'. ``` This change will get rid of the warnings without changing the output CSS.
mixonic
approved these changes
Aug 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After we have updated
ember-cli-sassto10, the following warningsstarted popping up:
This change will get rid of the warnings without changing the output
CSS.