Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ember 2.4+ does not need the assign polyfill #848

Merged
merged 1 commit into from
Jan 10, 2021

Conversation

NullVoxPopuli
Copy link
Contributor

No description provided.

@twokul
Copy link
Contributor

twokul commented Jan 7, 2021

Related to #819.

@twokul
Copy link
Contributor

twokul commented Jan 7, 2021

I am not sure we want to merge this into 3.0-beta just yet since we would like to drop all the "< Ember 2.4" targets but keep Ember 2.4, for now. I believe, assign appears in Ember proper in 2.5.

@mixonic
Copy link
Member

mixonic commented Jan 10, 2021

I believe the correct fix here is to use native Object.assign and stop using Ember's API at all. Then we can drop the polyfill. The browser support commitment for ember-table is fuzzy, but we're certainly not supporting IE11 in 3.0 and that was really the blocker on using Object.assign.

https://caniuse.com/mdn-javascript_builtins_object_assign

@mixonic
Copy link
Member

mixonic commented Jan 10, 2021

The only use of assign in Ember Table is Object.assign. So, I'm really not even sure what this dependency is doing. Certainly on our supported browsers it is doing nothing. Merging this.

@mixonic mixonic merged commit 44bb447 into Addepar:3.0-beta Jan 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants