Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @babel/* plugins as dev dependencies #862

Merged
merged 1 commit into from
Feb 3, 2021
Merged

Conversation

twokul
Copy link
Contributor

@twokul twokul commented Feb 3, 2021

A follow up on #861.

ET does not use @babel/preset-env (arguably, it should) so we have to
add the plugins we need manually. I forgot to do that in #861 - my bad.

One of the practical implications of this is that the consumers that do
not have these plugins enabled, will crash.

A follow up on #861.

ET does not use `@babel/preset-env` (arguably, it should) so we have to
add the plugins we need manually. I forgot to do that in #861 - my bad.

One of the practical implications of this is that the consumers that do
not have these plugins enabled, will crash.
@twokul twokul marked this pull request as ready for review February 3, 2021 15:25
@twokul twokul requested review from bantic and mixonic February 3, 2021 17:22
@twokul twokul merged commit 7a68e4f into 3.0-beta Feb 3, 2021
@twokul twokul deleted the twokul/babel-deps branch February 3, 2021 17:30
@twokul twokul mentioned this pull request Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants