Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "slack" width constraint modes #865

Merged
merged 28 commits into from
Feb 10, 2021
Merged
Changes from 2 commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
eca5789
Fix computed property dependency
ahmacleod Jan 27, 2021
ebdc177
Add new width constraint mode
ahmacleod Feb 2, 2021
1d92032
Improve slack handling
ahmacleod Feb 2, 2021
4c0a049
Update docs
ahmacleod Feb 2, 2021
77b0a79
Slack as fill mode
ahmacleod Feb 3, 2021
594119d
Refactor as two width constraint modes
ahmacleod Feb 3, 2021
eba10f9
Add tests for {eq,gte}-container-slack width constraints
ahmacleod Feb 4, 2021
287dbb0
Test for slack column absence in non-slack width constraint modes
ahmacleod Feb 4, 2021
3db0586
Quote the weird term
ahmacleod Feb 4, 2021
860a08b
Numbers go up
ahmacleod Feb 4, 2021
039656d
Page objects are nice
ahmacleod Feb 4, 2021
dc15cd4
Fix slack data attr for Ember 2.4
ahmacleod Feb 4, 2021
9fb5049
Fix mistake in docs
ahmacleod Feb 5, 2021
33f5c72
Initial fill mode + tests
ahmacleod Feb 8, 2021
99be989
Lint fix
ahmacleod Feb 8, 2021
39b2a64
Fix last col fill mode
ahmacleod Feb 8, 2021
9496542
Update docs for initial fill mode
ahmacleod Feb 8, 2021
79228ef
Resolve sass lint err
ahmacleod Feb 8, 2021
d4f7500
Improve docs for resizeMode
ahmacleod Feb 8, 2021
7353b5f
Maybe we can drop attribute nonsense now that 2.4 is out
ahmacleod Feb 8, 2021
7e292cc
Merge remote-tracking branch 'origin/3.0-beta' into alex.macleod.temp…
ahmacleod Feb 8, 2021
939ab07
Improve testing compatibility
ahmacleod Feb 8, 2021
222de9f
Revisions
ahmacleod Feb 9, 2021
5272398
adde-lint does NOT like ??
ahmacleod Feb 9, 2021
b05028d
Revert "Maybe we can drop attribute nonsense now that 2.4 is out"
ahmacleod Feb 9, 2021
b5b52de
Revert some stuff for testing
ahmacleod Feb 10, 2021
ed297c8
Revert "Revert some stuff for testing"
ahmacleod Feb 10, 2021
bc2dda1
Use slack mode CP and add comments
ahmacleod Feb 10, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,20 +1,20 @@
# Size Constraints

You can set the `widthConstraint` property on your table to ensure that it never
grows too big or too small. There are 4 possible settings:
grows too big or too small. There are six possible settings:

1. `eq-container`: Ensures that the table is always exactly the width the of its
container.

2. `eq-container-slack`: Similar to `eq-container`, but allocates excess whitespace to an empty slack column on the right side of the table.
2. `eq-container-slack`: Similar to `eq-container`, but allocates excess whitespace to an empty "slack" column on the right side of the table.

3. `gte-container`: Ensures that the table is always the same width or larger than its container.

4. `eq-container-slack`: Similar to `gte-container`, but allocates excess whitespace to an empty slack column on the right side of the table.
4. `eq-container-slack`: Similar to `gte-container`, but allocates excess whitespace to an empty "slack" column on the right side of the table.
ahmacleod marked this conversation as resolved.
Show resolved Hide resolved

5. `lte-container`: Ensures that the table is never larger than its container.

4. `none`: The default, does not enforce any size constraint.
6. `none`: The default, does not enforce any size constraint.

The table will react to resizing its container automatically. Sizing will _not_
override the min/max widths provided by columns.
Expand Down