Add is-last-column and is-slack classes to table cells #876
+303
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmacleod
force-pushed
the
alex.macleod.temp/indicate-last-column
branch
2 times, most recently
from
e769542 to
86dccd7
Compare
ahmacleod
force-pushed
the
alex.macleod.temp/indicate-last-column
branch
from
86dccd7 to
3ed58ca
Compare
ahmacleod
force-pushed
the
alex.macleod.temp/indicate-last-column
branch
from
3ed58ca to
492202c
Compare
twokul
approved these changes
Mar 18, 2021
| */ | ||
| contentHeaders: collection('th:not([data-test-ember-table-slack])', Header), | ||
| slackHeaders: collection('th[data-test-ember-table-slack]', Header), |
There was a problem hiding this comment.
I am assuming this private API. Is that correct?
There was a problem hiding this comment.
Good question. Moved "offline" for a broader discussion.
In this case, contentHeaders is redundant, unused internally, and new since 3.0. It's probably safe to assume nobody is using it. More clarity would be good here though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
is-slackclass to slackthandtdelementsis-last-columnclass to the rightmost column cells. In slack modes, the rightmost column can be either the slack column (when slack is visible) or its immediate neighbor to the left (when no slack is visible).is-first-columnclass