Added minimum jQuery UI build info to site #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The entire jQuery UI package weighs in at 228k after minifcation. The modules that are required for ember-table are only 55k after min. After digging through the code, it appears that only the following modules are required: * core * widgets * mouse * resizable * sortable So it would probably be helpful to include this info in the docs to avoid users downloading the entire package when it isn't necessary.
|
Thanks for this, @davewasmer! I'm merging it in now. I noticed that the jquery-ui files included in our dependencies/ folder use more than the modules you listed, but I'm leaving them as they are for now since our dependency management may change sometime soon. |
azirbel
added a commit
that referenced
this pull request
Feb 18, 2014
Added minimum jQuery UI build info to site
Gaurav0
pushed a commit
to Gaurav0/ember-table
that referenced
this pull request
Oct 13, 2015
Fix ember test and remove bind syntax. For emergency, others need to merge this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The entire jQuery UI package weighs in at 228k after minifcation. The modules that are required for ember-table are only 55k after min. After digging through the code, it appears that only the following modules are required:
So it would probably be helpful to include this info in the docs to avoid users downloading the entire package when it isn't necessary.