Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Property Fallback Lookup (no implicit this) #902

Merged
merged 1 commit into from
Aug 18, 2021

Conversation

johanrd
Copy link
Contributor

@johanrd johanrd commented Aug 18, 2021

See https://deprecations.emberjs.com/v3.x/#toc_this-property-fallback

Further work for another PR:
Read-only fields could perhaps be rewritten to use the @-syntax directly in the templates (for simplification).

E.g. resize-handle (and sort-indicator) could be a simple template-only component by using the @-syntax directly in the template:

-{{#if this.isResizable}}
+{{#if @columnsMeta.isResizable}}
  <div data-test-resize-handle class="et-header-resize-area">
  </div>
{{/if}}

See https://deprecations.emberjs.com/v3.x/#toc_this-property-fallback

Further work for another PR: Read-only fields could perhaps be rewritten to use the @-syntax directly in the templates (for simplification)
@mixonic mixonic merged commit 204315a into Addepar:master Aug 18, 2021
@johanrd johanrd deleted the no-implicit-this branch August 18, 2021 20:23
Arijit-Roy pushed a commit to xomaczar/ember-table that referenced this pull request Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants