Add missing peer dependency @babel/core@^7.0.0-0 #910
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When installing using
yarn
, there are many console warnings about an unmet peer dependency on@babel/core@^7.0.0-0
for some of the deps, such as@babel/plugin-proposal-object-rest-spread
.These warnings also show up when consumers do their yarn install, e.g.:
This PR adds an explicit dependency on babel/core to silence those warnings.
Doing a
yarn install
in ember-table locally before:And after:
I am taking inspiration from yarnpkg/yarn#5347 (comment) that recommends that package maintainers add the missing peer dep locally, when the yarn warning originates from their package.