Add ember-try scenario for ember v4 #940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mixonic
force-pushed
the
monroe/et4-this-property-fallback
branch
2 times, most recently
from
44584c0 to
8e19c74
Compare
Base automatically changed from
monroe/et4-this-property-fallback
to
4.0-beta
February 16, 2022 14:31
mixonic
force-pushed
the
monroe/et4-ember-try-4-scenario
branch
from
8f26136 to
9538831
Compare
mixonic
reviewed
Feb 16, 2022
kpfefferle
reviewed
Feb 23, 2022
kpfefferle
reviewed
Feb 23, 2022
kpfefferle
reviewed
Feb 23, 2022
| @@ -50,7 +33,6 @@ module('Unit | Private | ColumnTree', function(hooks) { | |||
| tree = ColumnTree.create({ | |||
| columns, | |||
| columnMetaCache, | |||
| rows: generateTree([0, [1, [2, 3], 4, [5, 6]]]), | |||
There was a problem hiding this comment.
This was causing some sort of error, but seems irrelevant to the test, right? A bit of explanation in a comment would be helpful for review.
kpfefferle
reviewed
Feb 23, 2022
DanMonroe
force-pushed
the
monroe/et4-ember-try-4-scenario
branch
from
fc9d6a7 to
b5afc2c
Compare
kpfefferle
reviewed
Feb 24, 2022
DanMonroe
force-pushed
the
monroe/et4-ember-try-4-scenario
branch
from
b5afc2c to
f5a8449
Compare
kpfefferle
approved these changes
Feb 24, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR requires an update to ember-class-page-object. It is pointing to a specific beta branch based that points to a beta branch of https://github.com/san650/ember-cli-page-object/tree/v2.0.0-beta.3