[TRIVIAL] Disable 3.16 scenario in CI #978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpfefferle
changed the title
DanMonroe
approved these changes
Feb 9, 2023
kpfefferle
force-pushed
the
kpfefferle/bump-ci-timeout
branch
from
b8ba5ca to
b1338cb
Compare
kpfefferle
force-pushed
the
kpfefferle/bump-ci-timeout
branch
from
b1338cb to
4c20684
Compare
kpfefferle
changed the title
|
Wow, even 10 minutes isn't enough time for 3.16 😬 - I'm going to try 15 minutes and then see how long they actually take to finish to see if that's excessive |
|
Of course with 15 minutes of room it finishes in 8m 🤷♂️ |
|
After discussion with @mixonic, we've decided to not run the 3.16 scenario in CI since it's the most inconsistent (but consistently slow) scenario. We'll leave it in the ember-try config for now until we officially drop support. |
kpfefferle
changed the title
mixonic
approved these changes
Feb 10, 2023
Co-authored-by: Matthew Beale <matt.beale@addepar.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Ember 3.12 and 3.16 tests don't reliably finish in under 7 minutes. This is currently blocking merge of #976 because the 3.16 tests need more time to run (a re-run of 3.12 did manage to finish in just under the timeout).
This PR bumps the GitHub Actions CI timeout from 7 minutes to 10 minutes.This PR disables the 3.16 scenario in CI since it's the slowest and most inconsistent scenario. It remains configured in ember-try should we need to debug any reported issues, but we will likely drop support for 3.12 and 3.16 altogether in the near future.