Skip to content
This repository has been archived by the owner on Jun 17, 2022. It is now read-only.

Use on modifier for expand toggle #40

Merged
merged 1 commit into from
Mar 14, 2019
Merged

Conversation

kpfefferle
Copy link
Member

@kpfefferle kpfefferle commented Mar 14, 2019

  • I pulled in ember-decorators as the {{on modifier wasn't working without the @action decorator
  • Installing ember-decorators tries to upgrade @ember-decorators/babel-transforms to ^3.1, but that breaks the build
  • Reverting ``@ember-decorators/babel-transformsto^2.1.2` gets everything working, though with a warning
  • Edit: I used a hack suggested by @mixonic to load the @export decorator from @ember/object until fix export -- current error: @ember/object does not have a action export emberjs/ember.js#17727 is resolved
  • Hopefully we'll get the native @action decorator unblocked so we can drop ember-decorators and it won't be an issue

This is a more obvious use of Element Modifiers for #32

@mixonic mixonic merged commit 950d844 into master Mar 14, 2019
@mixonic mixonic deleted the kpfefferle/on-modifier branch March 14, 2019 15:59
@rwjblue
Copy link
Contributor

rwjblue commented Mar 14, 2019

btw, I'm working on @action export stuff this afternoon

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants