-
-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compile library with API 31 #454
Conversation
IanArb
commented
Feb 25, 2022
- Update CameraActivity.kt to handle camera permissions
- Update CameraTest.java to handle case for deny permission
* Update CameraActivity.kt to handle camera permissions * Update CameraTest.java to handle case for deny permission
Hey @alorma @Sloy I managed to get it compiled against Android 12. However, there are some tests that were failing in previous builds and they are ok running locally. It seems to be trying failing due to the material components. Would this be considered a blocker for this if these tests are not passing? |
sample/src/main/java/com/adevinta/android/barista/sample/CameraActivity.kt
Outdated
Show resolved
Hide resolved
sample/src/androidTest/java/com/adevinta/android/barista/sample/CameraTest.java
Outdated
Show resolved
Hide resolved
If they didn't work on previous versions, it won't be a blocker to this PR. Don't worry! 😆 But feel free to open an issue, now that you've seen which tests didn't pass. Just to know the homework we have to do 😃 About my feedback, it's just a comment. I love having as simpler as possible Activities, so any code we could remove, I love the idea. That's why I think we could leave the CameraActivity as it was if we can, to keep this PR minimal. |
Hey @rocboronat I've reverted the camera activity changes and created an issue for the failing tests. #456 |
Great! I'll take a last look and merge it. Thannnnks a lot! 😊 |
Hey @rocboronat any follow up on this review? |
Hi @IanArb . We've updated the library to API 33. |