Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile library with API 31 #454

Closed

Conversation

IanArb
Copy link
Contributor

@IanArb IanArb commented Feb 25, 2022

  • Update CameraActivity.kt to handle camera permissions
  • Update CameraTest.java to handle case for deny permission

* Update CameraActivity.kt to handle camera permissions
* Update CameraTest.java to handle case for deny permission
@IanArb IanArb marked this pull request as draft February 25, 2022 11:49
@IanArb
Copy link
Contributor Author

IanArb commented Mar 1, 2022

Hey @alorma @Sloy I managed to get it compiled against Android 12. However, there are some tests that were failing in previous builds and they are ok running locally. It seems to be trying failing due to the material components. Would this be considered a blocker for this if these tests are not passing?
No view matching ((an instance of android.widget.TextView and view.getText() with or without transformation to match: is "Hi! I'm the second screen!" or (view.getParent() is assignable from class <class com.google.android.material.textfield.TextInputLayout> and (view is an instance of android.view.ViewGroup and has descendant matching an instance of android.widget.TextView and view.getText() with or without transformation to match: is "Hi! I'm the second screen!")))) was found

@IanArb IanArb marked this pull request as ready for review March 1, 2022 14:11
@rocboronat
Copy link
Member

Hey @alorma @Sloy I managed to get it compiled against Android 12. However, there are some tests that were failing in previous builds and they are ok running locally. It seems to be trying failing due to the material components. Would this be considered a blocker for this if these tests are not passing? No view matching ((an instance of android.widget.TextView and view.getText() with or without transformation to match: is "Hi! I'm the second screen!" or (view.getParent() is assignable from class <class com.google.android.material.textfield.TextInputLayout> and (view is an instance of android.view.ViewGroup and has descendant matching an instance of android.widget.TextView and view.getText() with or without transformation to match: is "Hi! I'm the second screen!")))) was found

If they didn't work on previous versions, it won't be a blocker to this PR. Don't worry! 😆 But feel free to open an issue, now that you've seen which tests didn't pass. Just to know the homework we have to do 😃

About my feedback, it's just a comment. I love having as simpler as possible Activities, so any code we could remove, I love the idea. That's why I think we could leave the CameraActivity as it was if we can, to keep this PR minimal.

@IanArb IanArb requested a review from rocboronat March 2, 2022 16:45
@IanArb
Copy link
Contributor Author

IanArb commented Mar 4, 2022

Hey @rocboronat I've reverted the camera activity changes and created an issue for the failing tests. #456

@rocboronat
Copy link
Member

Great! I'll take a last look and merge it. Thannnnks a lot! 😊

@IanArb
Copy link
Contributor Author

IanArb commented Mar 8, 2022

Hey @rocboronat I've reverted the camera activity changes and created an issue for the failing tests. #456

Hey @rocboronat any follow up on this review?

@alorma
Copy link
Member

alorma commented Dec 4, 2022

Hi @IanArb .

We've updated the library to API 33.

@alorma alorma closed this Dec 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants