ISSUE 339 - Solved crash with UndeliverableException on Geocoder #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieldisu
approved these changes
Mar 11, 2022
marcserrascmspain
approved these changes
Mar 11, 2022
delete-merged-branch
bot
deleted the
ISSUE-339-UndeliverableException-Geocoder
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE
#339
Description
There was a crash with Geocoder when an error is raised and the Disposable is already disposed. To solve this problem we have changed the place where the subscribe is done (from the repository to the presenter). Also we have replaced the Observable object to a Single to better manage the results and simplify the code.
Screenshots
No screens
Mandatory GIF