[NO ISSUE] Migrated Sample App main activity to Jetpack Compose #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlquintana
reviewed
May 13, 2022
| val context = LocalContext.current | ||
|
|
||
| Column(Modifier.padding(16.dp, 0.dp, 16.dp, 0.dp).fillMaxSize()) { | ||
| Spacer(modifier = Modifier.size(20.dp)) |
There was a problem hiding this comment.
You could replace all the Spacer(modifier = Modifier.size(20.dp)) with a parameter in the parent Column:
Column(
Modifier
.padding(horizontal = 16.dp)
.fillMaxSize(),
verticalArrangement = Arrangement.spacedBy(20.dp)
) {
There was a problem hiding this comment.
Many thanks for your suggestion!
jlquintana
reviewed
May 13, 2022
Comment on lines
+223
to
+227
| Button( | ||
| colors = ButtonDefaults.buttonColors( | ||
| backgroundColor = Color(context.resources.getColor(R.color.leku_app_blue)), | ||
| contentColor = Color.White | ||
| ), |
There was a problem hiding this comment.
It's ok for now, but you should use Theme color when you create the theme.
There was a problem hiding this comment.
Sure! The next step is to create the Theme for the picker activity :)
jlquintana
approved these changes
May 16, 2022
delete-merged-branch
bot
deleted the
NO-ISSUE-migration-to-jetpack-compose
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE
No issue
Description
In Order to migrate all the library to Jetpack Compose we started with adding Compose to the project and migrating the sample activity layout.
Screenshots
Mandatory GIF