Skip to content

Commit

Permalink
Remove Docker VOLUME instruction for more flexibility
Browse files Browse the repository at this point in the history
Inheriting from the base image is made easier without
the VOLUME instruction, since it cannot be reverted.
All guides contain `--volume` explanations/usage
examples anyway, so the VOLUME instructions in the
Dockerfile aren't necessary.

See also https://stackoverflow.com/a/62068396/11477374 for more
examples for why that instruction can be harmful.
  • Loading branch information
alexpovel committed Jan 21, 2021
1 parent 7fab31b commit 76e538c
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions scripts/make/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,6 @@ RUN setcap 'cap_net_bind_service=+eip' /opt/adguardhome/AdGuardHome

EXPOSE 53/tcp 53/udp 67/udp 68/udp 80/tcp 443/tcp 853/tcp 3000/tcp

VOLUME ["/opt/adguardhome/conf", "/opt/adguardhome/work"]

WORKDIR /opt/adguardhome/work

ENTRYPOINT ["/opt/adguardhome/AdGuardHome"]
Expand Down

0 comments on commit 76e538c

Please sign in to comment.