Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to go:build directives #2419

Open
ainar-g opened this issue Dec 11, 2020 · 2 comments
Open

Move to go:build directives #2419

ainar-g opened this issue Dec 11, 2020 · 2 comments
Assignees
Milestone

Comments

@ainar-g
Copy link
Contributor

ainar-g commented Dec 11, 2020

See the draft design. Go 1.16 is when we can add them, and Go 1.17 is when we can remove the old +build tags.

@ainar-g ainar-g added this to the v0.107.0 milestone Dec 11, 2020
@ainar-g ainar-g self-assigned this Dec 11, 2020
adguard pushed a commit that referenced this issue May 21, 2021
Closes #2576.
Updates #2275.
Updates #2419.
Updates #2443.

Squashed commit of the following:

commit b1a4809
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Fri May 21 14:01:40 2021 +0300

    all: add --local-frontend, upd docker

commit 619ee7c
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Thu May 20 15:02:33 2021 +0300

    bamboo-specs: bump docker version

commit 5c2b2fb
Merge: 6536b32 9c60aef
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Thu May 20 15:01:47 2021 +0300

    Merge branch 'master' into 2275-upd-go

commit 6536b32
Merge: 9bb32bc 6f7fd33
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Wed May 19 20:38:48 2021 +0300

    Merge branch 'master' into 2275-upd-go

commit 9bb32bc
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Wed May 19 18:48:50 2021 +0300

    all: fix build, imp err handling

commit 6868eac
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Wed May 19 18:09:32 2021 +0300

    all: fix github lint

commit ebbb9c5
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Wed May 19 17:36:56 2021 +0300

    all: update go and backend tools
@ainar-g
Copy link
Contributor Author

ainar-g commented May 21, 2021

The new directives are added. Moving to v0.108.0, which is probably when we can remove the old ones.

@ainar-g ainar-g modified the milestones: v0.107.0, v0.108.0 May 21, 2021
adguard pushed a commit that referenced this issue Jun 15, 2021
Updates #2419.

Squashed commit of the following:

commit e57e6ce
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Tue Jun 15 19:37:15 2021 +0300

    all: imp build tags
@ainar-g ainar-g modified the milestones: v0.108.0, v0.109.0 Dec 21, 2021
@ainar-g
Copy link
Contributor Author

ainar-g commented Dec 21, 2021

Go 1.17's gofmt still seems to add them. Moving to v0.109.0, which will probably use Go 1.18.

heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
Closes AdguardTeam#2576.
Updates AdguardTeam#2275.
Updates AdguardTeam#2419.
Updates AdguardTeam#2443.

Squashed commit of the following:

commit b1a4809
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Fri May 21 14:01:40 2021 +0300

    all: add --local-frontend, upd docker

commit 619ee7c
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Thu May 20 15:02:33 2021 +0300

    bamboo-specs: bump docker version

commit 5c2b2fb
Merge: 6536b32 9c60aef
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Thu May 20 15:01:47 2021 +0300

    Merge branch 'master' into 2275-upd-go

commit 6536b32
Merge: 9bb32bc 6f7fd33
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Wed May 19 20:38:48 2021 +0300

    Merge branch 'master' into 2275-upd-go

commit 9bb32bc
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Wed May 19 18:48:50 2021 +0300

    all: fix build, imp err handling

commit 6868eac
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Wed May 19 18:09:32 2021 +0300

    all: fix github lint

commit ebbb9c5
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Wed May 19 17:36:56 2021 +0300

    all: update go and backend tools
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
Updates AdguardTeam#2419.

Squashed commit of the following:

commit e57e6ce
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Tue Jun 15 19:37:15 2021 +0300

    all: imp build tags
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant