Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error while update check #2507

Closed
uservictor opened this issue Dec 30, 2020 · 9 comments
Closed

Error while update check #2507

uservictor opened this issue Dec 30, 2020 · 9 comments
Assignees
Labels
bug infrastructure CI, CD, releases, etc. P2: High
Milestone

Comments

@uservictor
Copy link

Hello I am using AdGuardHome v0.105.0-SNAPSHOT-5e20ac7e on my RaspberryPi 4B (32bit armv6 edge channel)
Recently I disconnected internet connection for about 10 minutes, after connecting again and going to admin webinterface I get this message:

Error: control/version.json | Couldn't get version check json from https://static.adguard.com/adguardhome/edge/version.json: *fmt.wrapError version.json: invalid character '}' looking for beginning of object key string | 502

After clicking few times on update button i get same message until the update button disappear (its not visible/selectable).

Have a nice day

@ddonindia
Copy link

ddonindia commented Dec 31, 2020

there is a syntax error in https://static.adguard.com/adguardhome/edge/version.json. I think we need remove last ","

{
  "version": "v0.105.0-SNAPSHOT-3706f559",
  "announcement": "AdGuard Home v0.105.0-SNAPSHOT-3706f559 is now available!",
  "announcement_url": "https://github.com/AdguardTeam/AdGuardHome/commits/master",
  "selfupdate_min_version": "0.0",

  "download_darwin_386": "https://static.adguard.com/adguardhome/edge/AdGuardHome_darwin_386.zip",
  "download_darwin_amd64": "https://static.adguard.com/adguardhome/edge/AdGuardHome_darwin_amd64.zip",
  "download_freebsd_386": "https://static.adguard.com/adguardhome/edge/AdGuardHome_freebsd_386.tar.gz",
  "download_freebsd_amd64": "https://static.adguard.com/adguardhome/edge/AdGuardHome_freebsd_amd64.tar.gz",
  "download_freebsd_arm64": "https://static.adguard.com/adguardhome/edge/AdGuardHome_freebsd_arm64.tar.gz",
  "download_freebsd_armv5": "https://static.adguard.com/adguardhome/edge/AdGuardHome_freebsd_armv5.tar.gz",
  "download_freebsd_armv6": "https://static.adguard.com/adguardhome/edge/AdGuardHome_freebsd_armv6.tar.gz",
  "download_freebsd_armv7": "https://static.adguard.com/adguardhome/edge/AdGuardHome_freebsd_armv7.tar.gz",
  "download_linux_386": "https://static.adguard.com/adguardhome/edge/AdGuardHome_linux_386.tar.gz",
  "download_linux_amd64": "https://static.adguard.com/adguardhome/edge/AdGuardHome_linux_amd64.tar.gz",
  "download_linux_arm64": "https://static.adguard.com/adguardhome/edge/AdGuardHome_linux_arm64.tar.gz",
  "download_linux_armv5": "https://static.adguard.com/adguardhome/edge/AdGuardHome_linux_armv5.tar.gz",
  "download_linux_armv6": "https://static.adguard.com/adguardhome/edge/AdGuardHome_linux_armv6.tar.gz",
  "download_linux_armv7": "https://static.adguard.com/adguardhome/edge/AdGuardHome_linux_armv7.tar.gz",
  "download_linux_mips64le_softfloat": "https://static.adguard.com/adguardhome/edge/AdGuardHome_linux_mips64le_softfloat.tar.gz",
  "download_linux_mips64_softfloat": "https://static.adguard.com/adguardhome/edge/AdGuardHome_linux_mips64_softfloat.tar.gz",
  "download_linux_mipsle_softfloat": "https://static.adguard.com/adguardhome/edge/AdGuardHome_linux_mipsle_softfloat.tar.gz",
  "download_linux_mips_softfloat": "https://static.adguard.com/adguardhome/edge/AdGuardHome_linux_mips_softfloat.tar.gz",
  "download_linux_ppc64le": "https://static.adguard.com/adguardhome/edge/AdGuardHome_linux_ppc64le.tar.gz",
  "download_windows_386": "https://static.adguard.com/adguardhome/edge/AdGuardHome_windows_386.zip",
  "download_windows_amd64": "https://static.adguard.com/adguardhome/edge/AdGuardHome_windows_amd64.zip",
}

@ainar-g ainar-g self-assigned this Dec 31, 2020
@ainar-g ainar-g added bug infrastructure CI, CD, releases, etc. P2: High labels Dec 31, 2020
@ainar-g ainar-g added this to the v0.105.0 milestone Dec 31, 2020
@ainar-g
Copy link
Contributor

ainar-g commented Dec 31, 2020

Thanks for reporting that! We're in the process of updating our release process, and this is one of the bugs we've accidentally introduced. We'll fix it in a few hours!

adguard pushed a commit that referenced this issue Dec 31, 2020
Merge in DNS/adguard-home from 2276-fix-release-3 to master

Updates #2276.
Updates #2507.

Squashed commit of the following:

commit 1f75697
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Thu Dec 31 13:45:25 2020 +0300

    scripts: fix build-release
@ainar-g
Copy link
Contributor

ainar-g commented Dec 31, 2020

Should be fixed as of snapshot 933ca2a. Can you please check if our solution fixes the issue for you?

@mgcWil
Copy link

mgcWil commented Dec 31, 2020

Hello, for me, no more error on the json file, but the archives are empty :(

@ddonindia
Copy link

ddonindia commented Dec 31, 2020

This error is gone with latest edge docker build for arm64

@ainar-g
Copy link
Contributor

ainar-g commented Dec 31, 2020

@mgcWil Thanks for testing, we're testing and rolling out another fix.

adguard pushed a commit that referenced this issue Dec 31, 2020
Merge in DNS/adguard-home from 2276-fix-zip to master

Updates #2276.
Updates #2507.

Squashed commit of the following:

commit 9bd2c53
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Thu Dec 31 17:12:53 2020 +0300

    scripts: zip output dir recursively
@ainar-g
Copy link
Contributor

ainar-g commented Dec 31, 2020

The Windows and macOS ZIP archives should be fixed as of 2298a9e.

@uservictor
Copy link
Author

On new version "v0.105.0-SNAPSHOT-2298a9ed" the error massage like in first post is solved.

It shows connection error now (thats fine while there is no internet connection at this time) but there is still a bug with the "check for updates button" he disappears after few clicks.

To reproduce it:
disconnect internet
check for update on agh ui
click few times on update button

have a nice day agh team

@ainar-g
Copy link
Contributor

ainar-g commented Jan 11, 2021

@uservictor, thanks for checking! As for the disappearing button, seems unrelated to this issue, but can you please file a separate issue about that? We'll try to fix it.

@ainar-g ainar-g closed this as completed Jan 26, 2021
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
Merge in DNS/adguard-home from 2276-fix-release-3 to master

Updates AdguardTeam#2276.
Updates AdguardTeam#2507.

Squashed commit of the following:

commit 1f75697
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Thu Dec 31 13:45:25 2020 +0300

    scripts: fix build-release
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
Merge in DNS/adguard-home from 2276-fix-zip to master

Updates AdguardTeam#2276.
Updates AdguardTeam#2507.

Squashed commit of the following:

commit 9bd2c53
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Thu Dec 31 17:12:53 2020 +0300

    scripts: zip output dir recursively
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug infrastructure CI, CD, releases, etc. P2: High
Projects
None yet
Development

No branches or pull requests

4 participants