Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After update to ersion: v0.106.0-a.63+97361234 all static DHCP leases are gone. #2834

Closed
3 tasks done
keshabit opened this issue Mar 17, 2021 · 9 comments
Closed
3 tasks done
Assignees
Milestone

Comments

@keshabit
Copy link

keshabit commented Mar 17, 2021

After update to version: v0.106.0-a.63+97361234 all static DHCP leases are gone. It was working without any problems.

My Adguard setup using RPI4 on raspbian. Pls help ASAP.

Have a question or an idea? Please search it on our forum to make sure it was not yet asked. If you cannot find what you had in mind, please submit it here.

Prerequisites

Please answer the following questions for yourself before submitting an issue. YOU MAY DELETE THE PREREQUISITES SECTION.

  • I am running the latest version
  • I checked the documentation and found no answer
  • I checked to make sure that this issue has not already been filed

Issue Details

  • Version of AdGuard Home server:
  • How did you install AdGuard Home:
  • How did you setup DNS configuration:
  • If it's a router or IoT, please write device model:
  • CPU architecture:
  • Operating system and version:

Expected Behavior

Actual Behavior

Screenshots

Screenshot:

Additional Information

@keshabit
Copy link
Author

Pre-requisites updated.

@ainar-g ainar-g self-assigned this Mar 17, 2021
@ainar-g ainar-g added this to the v0.106.0 milestone Mar 17, 2021
@ainar-g
Copy link
Contributor

ainar-g commented Mar 17, 2021

Thanks for the report, investigating.

adguard pushed a commit that referenced this issue Mar 17, 2021
Updates #2541.
Updates #2834.

Squashed commit of the following:

commit d158018
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Wed Mar 17 14:51:43 2021 +0300

    all: doc changes; imp naming

commit f036b50
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Wed Mar 17 14:09:19 2021 +0300

    dhcpd: fix static leases
@ainar-g
Copy link
Contributor

ainar-g commented Mar 17, 2021

There is a good chance that your static leases can still be recovered. If you open the file leases.db and replace all instances where it says something like "exp":-62135596800 (where -62135596800 is any large negative number) with "exp":1.

The main issue, along with a couple of others, should be fixed on the edge channel as of snapshot 5243399. Apologies for the bug!

@keshabit
Copy link
Author

This issue is not fixed yet! I upgraded to the patch Version: v0.106.0-a.67+5243399d and I added one static IP it worked but when I added all IPs of my segment it again displayed that no IP configured in static lease therefore many leases configuration issue persists. Also, pls let us know where is the IP definition fine it so difficult to input one by one static leases configuration.

@ainar-g
Copy link
Contributor

ainar-g commented Mar 18, 2021

I upgraded to the patch Version: v0.106.0-a.67+5243399d and I added one static IP it worked but when I added all IPs of my segment it again displayed that no IP configured in static lease therefore many leases configuration issue persists.

That's odd, we cannot reproduce it. Could you please provide answers to the following answers:

  1. Are the static IPs that you are setting within the range you entered and within the subnet mask? See also Better subnet validation, static DHCP leases outside of dynamic IP range #2838.
  2. Can you provide the verbose logs of AdGuard Home when you add the static leases?

We will keep testing in the meantime.

Also, pls let us know where is the IP definition fine it so difficult to input one by one static leases configuration.

The leases.db file I mentioned earlier is a plain JSON file where the leases are stored, but the format is not stable and not designed to be edited manually. We will consider adding an easier way to import several static leases in the following releases.

@keshabit
Copy link
Author

I am able to reproduce the scenario: is it expected, if we change the range of DHCP IP addresses (for dynamic allocation), DHCP Static leases field will go blank, even if it's not intersecting or mutually exclusive.

@keshabit
Copy link
Author

Again, I added 12 IPs and I refreshed and "BOOM" all gone. No change in config while leases definition or dynamic allocation. I'm so tired of this. :(

adguard pushed a commit that referenced this issue Mar 18, 2021
Closes #2838.
Updates #2834.

Squashed commit of the following:

commit 608dce2
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Thu Mar 18 16:49:20 2021 +0300

    dhcpd: fix windows; imp code

commit 5e56eeb
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Wed Mar 17 18:47:54 2021 +0300

    dhcpd: imp static lease validation
@ainar-g
Copy link
Contributor

ainar-g commented Mar 18, 2021

We're sorry for the inconvenience. The snapshot eb9526c should fix #2838, as well as a couple of other DHCP bugs. If that one still doesn't fix the issue for you, please provide all of the information that was requested before, because we really need it to diagnose the issue better. That is:

  1. The IP range and the subnet mask you entered.
  2. If the static lease IP addresses are within the subnet.
  3. Verbose logs.
  4. The state of your leases.db and if you applied the manual fix provided above.

@keshabit
Copy link
Author

My complains ends here, thank you @ainar-g appreciate your swift fixes!

heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
Updates AdguardTeam#2541.
Updates AdguardTeam#2834.

Squashed commit of the following:

commit d158018
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Wed Mar 17 14:51:43 2021 +0300

    all: doc changes; imp naming

commit f036b50
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Wed Mar 17 14:09:19 2021 +0300

    dhcpd: fix static leases
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
Closes AdguardTeam#2838.
Updates AdguardTeam#2834.

Squashed commit of the following:

commit 608dce2
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Thu Mar 18 16:49:20 2021 +0300

    dhcpd: fix windows; imp code

commit 5e56eeb
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Wed Mar 17 18:47:54 2021 +0300

    dhcpd: imp static lease validation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants