Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict the access to the private hosts from the external networks #2889

Closed
EugeneOne1 opened this issue Mar 29, 2021 · 2 comments
Closed

Restrict the access to the private hosts from the external networks #2889

EugeneOne1 opened this issue Mar 29, 2021 · 2 comments
Assignees
@EugeneOne1
Labels
enhancement P3: Medium
Milestone
v0.106.0

Comments

@EugeneOne1
Copy link
Member

EugeneOne1 commented Mar 29, 2021 •
edited
Loading

Our autohosts feature works for any client for now. But just like in #2704, it's obvious that the external clients shouldn't be able to resolve such hosts.
@EugeneOne1 EugeneOne1 added this to the v0.106.0 milestone Mar 29, 2021
@EugeneOne1 EugeneOne1 self-assigned this Mar 29, 2021
@EntropySmoke
Copy link

This issue is so confusing... Are you saying that random people can connect to my local AdGuard Home device from WAN and use it as a DNS resolver? I do set my local AdGuard Home IP for WAN DNS IP address to make sure it filters all outbound DNS traffic, but I it to filter traffic only for local clients, not for someone from WAN.

@ainar-g
Copy link
Contributor

ainar-g commented Apr 5, 2021

@EntropySmoke, this issue is about resolving of automatic hosts (the .lan ones) in private networks. AdGuard Home won't accept external queries unless you configure it to listen on an externally visible address or 0.0.0.0.

@adguard adguard closed this as completed in 7afc692 Apr 8, 2021
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
@EugeneOne1 @heyxkhoa
Pull request: 2889 internal hosts restriction
485eeb0 
Merge in DNS/adguard-home from 2889-imp-autohosts to master

Closes AdguardTeam#2889.

Squashed commit of the following:

commit 1d3b649
Merge: abc6e1c 1a214ea
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Thu Apr 8 17:59:51 2021 +0300

    Merge branch 'master' into 2889-imp-autohosts

commit abc6e1c
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Thu Apr 8 17:34:56 2021 +0300

    dnsforward: imp code

commit 4b2b914
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Thu Apr 8 17:31:34 2021 +0300

    dnsforward: respond with nxdomain

commit 8146674
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Tue Apr 6 19:16:14 2021 +0300

    dnsforward: restrict the access to intl hosts for ext clients
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EugeneOne1 EugeneOne1

Labels
enhancement P3: Medium
Projects
None yet
Milestone
v0.106.0
Development

No branches or pull requests
3 participants
@ainar-g @EntropySmoke @EugeneOne1