Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fastest IP: do not probe when there's just a single IP in the response #3315

Closed
tony198911 opened this issue Jul 6, 2021 · 2 comments
Closed

Fastest IP: do not probe when there's just a single IP in the response #3315

tony198911 opened this issue Jul 6, 2021 · 2 comments
Assignees
@ainar-g
Labels
enhancement external libs Issues that require changes in external libraries. P3: Medium
Milestone
v0.107.0

Comments

@tony198911
Copy link

tony198911 commented Jul 6, 2021 •
edited
Loading

Prerequisites

Please answer the following questions for yourself before submitting an issue. YOU MAY DELETE THE PREREQUISITES SECTION.

  • [*] I am running the latest version
  • [*] I checked the documentation and found no answer
  • [*] I checked to make sure that this issue has not already been filed

Problem Description

Some domains just have one IP address, and the IP will not open with 80 or 443, once ADG (DNS settings->Fastest IP address) meet these kind of IP will not pass the IP back until time out (like 1sec).
pic as below
https://github.com/tony198911/build-openwrt/blob/a548314b77413e89dd06f1234171dee429cb74e4/adg_1.png

Proposed Solution

When domain just have one IP, just skip the speed check.

Alternatives Considered

Additional Information

Thank you for your contribution! ADG is Great!
@ameshkov ameshkov changed the title About Fastest IP address Fastest IP: do not probe when there's just a single IP in the response Jul 6, 2021
@ainar-g ainar-g self-assigned this Jul 6, 2021
@ainar-g ainar-g added enhancement external libs Issues that require changes in external libraries. P3: Medium labels Jul 6, 2021
@ainar-g ainar-g added this to the v0.107.0 milestone Jul 6, 2021
adguard pushed a commit to AdguardTeam/dnsproxy that referenced this issue Jul 6, 2021
@ameshkov
Pull request: Do not ping when there's a single IP in the response
f08b078 
Merge in DNS/dnsproxy from fastip-single-ip to master

Updates AdguardTeam/AdGuardHome#3315

Squashed commit of the following:

commit 9dfb8ee
Author: Andrey Meshkov <am@adguard.com>
Date:   Tue Jul 6 12:38:53 2021 +0300

    use NoError

commit fd840ee
Author: Andrey Meshkov <am@adguard.com>
Date:   Tue Jul 6 11:40:54 2021 +0300

    Do not ping when there's a single IP in the response
adguard pushed a commit that referenced this issue Jul 6, 2021
@ainar-g
Pull request #1237: all: upd dnsproxy
4b5a66e 
Updates #3315.

Squashed commit of the following:

commit f91b979
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Tue Jul 6 13:48:29 2021 +0300

    all: upd dnsproxy
@ainar-g
Copy link
Contributor

ainar-g commented Jul 6, 2021

This should be implemented as of 4b5a66e. Can you please check if our solution works for you?

@tony198911
Copy link
Author

This should be implemented as of 4b5a66e. Can you please check if our solution works for you?

solved, thx :)

@ainar-g ainar-g closed this as completed Jul 12, 2021
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
@ainar-g @heyxkhoa
Pull request AdguardTeam#1237: all: upd dnsproxy
1587497 
Updates AdguardTeam#3315.

Squashed commit of the following:

commit f91b979
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Tue Jul 6 13:48:29 2021 +0300

    all: upd dnsproxy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ainar-g ainar-g

Labels
enhancement external libs Issues that require changes in external libraries. P3: Medium
Projects
None yet
Milestone
v0.107.0
Development

No branches or pull requests
2 participants
@ainar-g @tony198911