Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the local_domain_name from dns section into dhcp section #3367

Closed
ainar-g opened this issue Jul 22, 2021 · 0 comments
Closed

Move the local_domain_name from dns section into dhcp section #3367

ainar-g opened this issue Jul 22, 2021 · 0 comments
Assignees
@ainar-g
Labels
enhancement P4: Low
Milestone
v0.107.7

Comments

@ainar-g
Copy link
Contributor

ainar-g commented Jul 22, 2021

In #3003 we've documented what local_domain_name is actually about. If there are no changes to this setting, it's probably better to move it to the DHCP section, since it currently concerns only the DHCP clients' hosts.
@ainar-g ainar-g added this to the v0.108.0 milestone Jul 22, 2021
@ainar-g ainar-g self-assigned this Jul 22, 2021
@ainar-g ainar-g modified the milestones: v0.108.0, v0.107.7 Jun 2, 2022
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
@ainar-g @heyxkhoa
Pull request: home: mv local domain name to dhcp setts
cc61222 
Closes AdguardTeam#3367.

Squashed commit of the following:

commit e2cabca
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Tue Jan 25 19:35:31 2022 +0300

    home: imp test, skip dhcp test on windows

commit e58053f
Merge: ff2fe87 0b72bcc
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Tue Jan 25 19:10:25 2022 +0300

    Merge branch 'master' into 3367-dhcp-local-domain-name

commit ff2fe87
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Thu Dec 30 20:55:34 2021 +0300

    home: mv local domain name to dhcp setts
ehsan11100 pushed a commit to ehsan11100/AdGuard that referenced this issue Mar 26, 2024
@ainar-g
Pull request: Configuration: upd local_domain_name
e3bf36b 
Updates AdguardTeam/AdGuardHome#3367.

Squashed commit of the following:

commit 52f163f81992d13ea253d43661071a987c913caf
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Tue Jan 25 19:37:42 2022 +0300

    Configuration: fix cidr

commit b2105d93878ab71b8e94646ece9f78ce4afd8340
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Tue Jan 25 19:34:17 2022 +0300

    Configuration: upd local_domain_name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ainar-g ainar-g

Labels
enhancement P4: Low
Projects
None yet
Milestone
v0.107.7
Development

No branches or pull requests
1 participant
@ainar-g