Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Entries with two vertical lines in front and one after, are not recognised as valid entries. #3371

Closed
3 tasks done
DandelionSprout opened this issue Jul 23, 2021 · 4 comments
Closed
3 tasks done

Entries with two vertical lines in front and one after, are not recognised as valid entries. #3371

DandelionSprout opened this issue Jul 23, 2021 · 4 comments
Assignees
@EugeneOne1
Labels
bug external libs Issues that require changes in external libraries. P4: Low
Milestone
v0.107.0

Comments

@DandelionSprout
Copy link
Member

DandelionSprout commented Jul 23, 2021 •
edited
Loading

Prerequisites

Please answer the following questions for yourself before submitting an issue. YOU MAY DELETE THE PREREQUISITES SECTION.

  • I am running the latest version
  • I checked the documentation and found no answer
  • I checked to make sure that this issue has not already been filed

Issue Details

  • Version of AdGuard Home server:
    • v0.107.0-b.5
  • How did you install AdGuard Home:
    • GitHub releases
  • How did you setup DNS configuration:
    • N/A
  • If it's a router or IoT, please write device model:
    • Raspberry Pi 4 8GB
  • CPU architecture:
    • ARM64
  • Operating system and version:
    • Fedora Workstation 34

Expected Behavior

Entries with two vertical lines in front and one after, e.g. ||example.org|, should be recognised by AdGuard Home as valid entries, because || means to block all subdomains, while | means end-of-domain.

Actual Behavior

The "Check the filtering" function does not recognise ||example.org|, @@||example.org|, or ||www.nrk.no| as valid entries.

Screenshots

Screenshot:

image

Additional Information

This discovery was the result of in-depth research for #3369, and was meant to be rather important for the "Doomed until proven to work" attempt to unblock vk.com across all major adblockers and AdGuard Home in https://github.com/DandelionSprout/adfilt/blob/f86e04ff345afa2090e22b7643f21e370389543c/FalukorvList.txt#L75-L82, until I simply went with @@/(^|/)vk\.com/?$/ instead.
@ainar-g ainar-g added bug external libs Issues that require changes in external libraries. needs investigation Needs to be reproduced reliably. P4: Low labels Jul 23, 2021
@ameshkov ameshkov removed the needs investigation Needs to be reproduced reliably. label Jul 28, 2021
@ameshkov ameshkov added this to the v0.107.0 milestone Jul 28, 2021
@ameshkov
Copy link
Member

@ainar-g this is a legit bug, we have such rules in the AdGuard DNS filter.

@DandelionSprout
Copy link
Member Author

Doesn't seem like EugeneOne1 ever took care of this, as the problem still remains.

adguard pushed a commit to AdguardTeam/urlfilter that referenced this issue Nov 10, 2021
@EugeneOne1
Pull request: 3371 fix pipe matching
55b2213 
Merge in DNS/urlfilter from 3371-rules-parsing to master

Updates AdguardTeam/AdGuardHome#3371.

Squashed commit of the following:

commit 7f452cc
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Wed Oct 27 13:06:30 2021 +0300

    rules: fix pipe matching
adguard pushed a commit that referenced this issue Nov 11, 2021
@EugeneOne1
Pull request: 3371 pipe-tailed rules
884a985 
Merge in DNS/adguard-home from 3371-rules-validation to master

Updates #3371.

Squashed commit of the following:

commit 7881a0b
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Thu Nov 11 15:06:42 2021 +0300

    all: imp code, docs

commit 613775a
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Tue Nov 2 16:50:43 2021 +0300

    all: upd urlfilter
@EugeneOne1
Copy link
Member

@DandelionSprout, finally, the latest build in the edge channel should fix the matching of this kind of rules. Could you please check if it does?

@DandelionSprout
Copy link
Member Author

I can confirm it works now. Thanks again.

heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
@EugeneOne1 @heyxkhoa
Pull request: 3371 pipe-tailed rules
0752669 
Merge in DNS/adguard-home from 3371-rules-validation to master

Updates AdguardTeam#3371.

Squashed commit of the following:

commit 7881a0b
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Thu Nov 11 15:06:42 2021 +0300

    all: imp code, docs

commit 613775a
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Tue Nov 2 16:50:43 2021 +0300

    all: upd urlfilter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EugeneOne1 EugeneOne1

Labels
bug external libs Issues that require changes in external libraries. P4: Low
Projects
None yet
Milestone
v0.107.0
Development

No branches or pull requests
4 participants
@ainar-g @ameshkov @DandelionSprout @EugeneOne1