Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNSCrypt queries aren't showing up in the query log at all #3372

Closed
3 tasks done
DandelionSprout opened this issue Jul 23, 2021 · 5 comments
Closed
3 tasks done

DNSCrypt queries aren't showing up in the query log at all #3372

DandelionSprout opened this issue Jul 23, 2021 · 5 comments
Assignees
Milestone

Comments

@DandelionSprout
Copy link
Member

DandelionSprout commented Jul 23, 2021

Have a question or an idea? Please search it on our forum to make sure it was not yet asked. If you cannot find what you had in mind, please submit it here.

Prerequisites

Please answer the following questions for yourself before submitting an issue. YOU MAY DELETE THE PREREQUISITES SECTION.

  • I am running the latest version
  • I checked the documentation and found no answer
  • I checked to make sure that this issue has not already been filed

Issue Details

  • Version of AdGuard Home server:
    • v0.107.0-b.5
  • How did you install AdGuard Home:
    • GitHub releases
  • How did you setup DNS configuration:
    • System
  • If it's a router or IoT, please write device model:
    • Raspberry Pi 4 8GB
  • CPU architecture:
    • ARM64
  • Operating system and version:
    • Fedora Workstation 34

Expected Behavior

Queries made by DNSCrypt clients, show up in the query log.

Actual Behavior

After I was able to generate a working DNSCrypt address, namely sdns://AQEAAAAAAAAAEjg0LjIwMi40NC41Mzo1NjQwNCDsdKplWV-GlLOA-lEBpZ11QS381gnDyqpTXz5sSwTaeSwyLmRuc2NyeXB0LWNlcnQuZGFuZGVsaW9uc3Byb3V0LmFzdXNjb21tLmNvbQ, it didn't take long until I discovered that there weren't any DNSCrypt-tagged queries in the query logs... and that no queries were shown in the log of the two DNSCrypt clients I had set up to use that sdns:// address.

This is despite the fact that they are being logged in the verbose log file. Furthermore, entries that are blocked on my server, e.g. brighteon.social, are still being blocked as intended for those two DNSCrypt clients.

Additionally, roughly 15% of the times I try to refresh the query log, the error Error: control/querylog?search=&response_status=&older_than=&limit=20 | Network Error shows up. The log is also somewhat slower than normal to load in general.

Screenshots

Screenshot:

↓ Notice the absence of any queries from clients with the text "PC" or "Moto One Zoom", the two units I had set up DNSCrypt on in their AdGuard for Windows/Android installations.

image

↓ This was the config I used to generate the DNS stamp. I feel very certain I had (and have) the "No logs" button unchecked.

image

Additional Information

Related to, but not a clone of, #2662

@DandelionSprout
Copy link
Member Author

DandelionSprout commented Jul 23, 2021

I'm seldom the best at looking through verbose debug logs, but one type of line in the log I linked to above, has drawn my attention since I posted the OP:

2021/07/24 00:43:14.788226 2643#214 [error] querylog: adding record: no client ip, skipping

wut

@ainar-g ainar-g self-assigned this Jul 26, 2021
@ainar-g ainar-g added the needs investigation Needs to be reproduced reliably. label Jul 26, 2021
@ainar-g ainar-g assigned EugeneOne1 and unassigned ainar-g Jul 27, 2021
@ainar-g ainar-g added bug P3: Medium and removed needs investigation Needs to be reproduced reliably. labels Jul 27, 2021
@ainar-g ainar-g added this to the v0.107.0 milestone Jul 27, 2021
@ainar-g
Copy link
Contributor

ainar-g commented Jul 27, 2021

Thank you for your report and sorry for the long waiting. I've confirmed that something is definitely wrong there. We'll fix it in the nearest couple of days.

adguard pushed a commit that referenced this issue Jul 27, 2021
Merge in DNS/adguard-home from 3372-dnscrypt-logs to master

Updates #3372.

Squashed commit of the following:

commit 6033832
Merge: c0379e2 f2046a5
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Tue Jul 27 19:05:18 2021 +0300

    Merge branch 'master' into 3372-dnscrypt-logs

commit c0379e2
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Tue Jul 27 18:58:07 2021 +0300

    all: fix log of changes

commit 7ba9dba
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Tue Jul 27 18:54:05 2021 +0300

    all: log changes

commit dbf1076
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Tue Jul 27 18:09:51 2021 +0300

    all: upd dnscrypt
@EugeneOne1
Copy link
Member

@DandelionSprout, this should be fixed in the latest edge build. Could you please install it and check if our solution works for you?

@DandelionSprout
Copy link
Member Author

I'll make sure to test it tomorrow.

@DandelionSprout
Copy link
Member Author

Seems to indeed have been fixed in v0.107.0-a.113+fc063f58

heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
Merge in DNS/adguard-home from 3372-dnscrypt-logs to master

Updates AdguardTeam#3372.

Squashed commit of the following:

commit 6033832
Merge: c0379e2 f2046a5
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Tue Jul 27 19:05:18 2021 +0300

    Merge branch 'master' into 3372-dnscrypt-logs

commit c0379e2
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Tue Jul 27 18:58:07 2021 +0300

    all: fix log of changes

commit 7ba9dba
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Tue Jul 27 18:54:05 2021 +0300

    all: log changes

commit dbf1076
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Tue Jul 27 18:09:51 2021 +0300

    all: upd dnscrypt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants