Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panic when validating TLS certificate #3411

Closed
Chinaski1 opened this issue Aug 3, 2021 · 1 comment
Closed

Panic when validating TLS certificate #3411

Chinaski1 opened this issue Aug 3, 2021 · 1 comment
Assignees
@ainar-g
Labels
bug P2: High
Milestone
v0.107.0

Comments

@Chinaski1
Copy link
Member

Issue Details

  • Version of AdGuard Home server:

    • v0.107.0-b.6

  • How did you install AdGuard Home:

    • GitHub releases

  • Operating system and version:

    • macOS BigSur version: 11.5 (20G71)

Steps to reproduce

  1. Run AdGuard Home service
  2. Open web interface and go to Encryption settings
  3. Enter the server name, Enable Redirect to HTTPS automatically feature, set certificate path, set a private key and press Save configurations
  4. Wait for a while (usually less than a minute)
  5. AdGuard Home service stops responding

Note: In my case is being used Certificate with invalid chain

Logs

2021/08/03 17:09:49.368860 2750#15 [debug] web: plain: http: panic serving 127.0.0.1:53048: cannot handle unexported field at {home.tlsConfigSettings}.TLSConfig.cert:
"github.com/AdguardTeam/AdGuardHome/internal/dnsforward".TLSConfig
consider using a custom Comparer; if you control the implementation of type, you can also consider using an Exporter, AllowUnexported, or cmpopts.IgnoreUnexported
@Chinaski1 Chinaski1 added the bug label Aug 3, 2021
@ainar-g ainar-g self-assigned this Aug 3, 2021
@ainar-g ainar-g added this to the v0.107.0 milestone Aug 3, 2021
@adguard adguard closed this as completed in 5c2ead5 Aug 3, 2021
@ainar-g
Copy link
Contributor

ainar-g commented Aug 3, 2021

Will ship in the next few days with v0.107.0-b.7.

heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
@ainar-g @heyxkhoa
Pull request: home: fix tls config comparison
c3710c6 
Closes AdguardTeam#3411.

Squashed commit of the following:

commit 42deaa1
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Tue Aug 3 19:47:32 2021 +0300

    home: imp code

commit a69f646
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Tue Aug 3 18:54:59 2021 +0300

    home: fix tls config comparison
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ainar-g ainar-g

Labels
bug P2: High
Projects
None yet
Milestone
v0.107.0
Development

No branches or pull requests
2 participants
@ainar-g @Chinaski1