Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconsider DHCP option logic #3538

Closed
ainar-g opened this issue Sep 2, 2021 · 0 comments
Closed

Reconsider DHCP option logic #3538

ainar-g opened this issue Sep 2, 2021 · 0 comments
Assignees
@EugeneOne1
Labels
enhancement P2: High research Looking up ways to improve the product in the future.
Milestone
v0.107.0

Comments

@ainar-g
Copy link
Contributor

ainar-g commented Sep 2, 2021

It seems like some clients don't like having certain options sent to them. We should research what do the RFCs say about the algorithms of option selection and implement that in AGH.

The one bit that makes this a bit harder is the fact that we can add more options through the configuration file. We need to make a decision on whether those override the algorithm we choose for the default options.
@ainar-g ainar-g added enhancement P2: High research Looking up ways to improve the product in the future. labels Sep 2, 2021
@ainar-g ainar-g added this to the v0.107.0 milestone Sep 2, 2021
@EugeneOne1 EugeneOne1 mentioned this issue Oct 18, 2021
Closed
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
@EugeneOne1 @heyxkhoa
Pull request: 3538 dhcp options
b87d67f 
Merge in DNS/adguard-home from 3538-dhcp-options to master

Closes AdguardTeam#3538.
Updates AdguardTeam#3366.

Squashed commit of the following:

commit 8b8cd11
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Mon Sep 13 19:57:09 2021 +0300

    dhcpd: imp tests

commit 1789171
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Mon Sep 13 19:04:12 2021 +0300

    dhcpd: fix ip version

commit 07108a9
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Mon Sep 13 18:56:21 2021 +0300

    all: imp log of changes

commit 461441b
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Mon Sep 13 18:48:55 2021 +0300

    dhcpd: imp code & docs, log changes

commit 723f818
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Mon Sep 13 17:27:30 2021 +0300

    dhcpd: add default options

commit 575e9d0
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Wed Sep 8 13:05:01 2021 +0300

    dhcpd: imp options logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EugeneOne1 EugeneOne1

Labels
enhancement P2: High research Looking up ways to improve the product in the future.
Projects
None yet
Milestone
v0.107.0
Development

No branches or pull requests
2 participants
@ainar-g @EugeneOne1