OpenWRT: command "arp" has failed

[timkgh]

2021/09/15 01:06:11.931024 24345#18 [debug] command "arp" has failed: "exec: \"arp\": executable file not found in $PATH" code:-1

On OpenWRT arp seems to be defined as a shell function arp() { cat /proc/net/arp; }

Should AGH switch to using ip neigh if ip is installed and fall back to arp, if it exists as an executable or just look in /proc/net/arp?

[ainar-g]

Hello and thanks for the suggestion. I actually see a few issues in our current implementation:

1. AGH doesn't use alternative ways of getting the ARP info from the kernel, including /proc/net/arp and ip neigh.

2. AGH doesn't stop the attempts to get the client info after several failures. One could assume that this is a feature, since the arp binary can technically still appear later, but I personally think that this is a rather weak excuse.

3. This functionality should really be moved to package aghnet and not just stay in package home.

I think we can refactor it all together in the v0.108 cycle.

[EugeneOne1]

@timkgh, hello again. We've improved ARP-related logic a bit. It's available in the latest edge build and it should use some different sources of data including parsing the /proc/net/arp file. It should also notify about occured errors only once at the start. Could you please check if it fixes the issue for you?

[EugeneOne1]

@timkgh, hello. I'll close the issue for now. Feel free to file new ones if you'll face any bugs with our solution.