Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IP address can be used as a Client ID in mobile config #3684

Closed
Chinaski1 opened this issue Sep 30, 2021 · 1 comment
Closed

IP address can be used as a Client ID in mobile config #3684

Chinaski1 opened this issue Sep 30, 2021 · 1 comment
Assignees
@IldarKamalov
Labels
bug P3: Medium
Milestone
v0.107.0

Comments

@Chinaski1
Copy link
Member

Issue Details

  • Version of AdGuard Home server:
    • v0.107.0-b.12

Steps to reproduce

  1. Enable and configure Encryption settings
  2. Open Setup Guide page -> DNS privacy
  3. Set the IP address in the Client ID settings
  4. Click Download configuration file
  5. Network error

Expected behavior

The settings must not accept the IP address because it is not a Client ID
@Chinaski1 Chinaski1 added this to the v0.107.0 milestone Sep 30, 2021
@carrot-eggs
Copy link

I encountered the same problem!

heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
@IldarKamalov @heyxkhoa
Pull request: 3684 validate client id in the mobileconfig form
d724db2 
Closes AdguardTeam#3684

Squashed commit of the following:

commit 78e9862
Author: Ildar Kamalov <ik@adguard.com>
Date:   Fri Oct 15 14:39:36 2021 +0300

    fix build

commit 3ed4ee6
Author: Ildar Kamalov <ik@adguard.com>
Date:   Fri Oct 15 13:39:12 2021 +0300

    client: validate client id in the mobileconfig form
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IldarKamalov IldarKamalov

Labels
bug P3: Medium
Projects
None yet
Milestone
v0.107.0
Development

No branches or pull requests
3 participants
@IldarKamalov @carrot-eggs @Chinaski1