-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GUI improvement: Client Settings Page - Contextual Sorting when clicking on column headers #4143
Comments
Thanks for the report! How would you prefer the clients to be sorted when a CIDR, a MAC, or a ClientID is used? The fact is, the client identifiers are text that is interpreted differently depending on the content. I think we could use the IP comparison if both identifiers are IP addresses and switch to text comparison if either one of them is text, but I'm not sure. @IldarKamalov, would that be feasible? |
I think mathematical number sort (if any numbers are involved, else text). |
Merge in DNS/adguard-home from 4143-clients-sort to master Updates #4143. Squashed commit of the following: commit a4b547e Merge: d369c11 d82b290 Author: Ildar Kamalov <ik@adguard.com> Date: Thu Jan 20 11:58:42 2022 +0300 Merge branch 'master' into 4143-clients-sort commit d369c11 Author: Ildar Kamalov <ik@adguard.com> Date: Wed Jan 19 16:53:39 2022 +0300 client: fix sort ip method commit d767a11 Author: Ildar Kamalov <ik@adguard.com> Date: Wed Jan 19 16:23:23 2022 +0300 client: sort client ids
@gspannu, I think you mean what is called natural sorting. We'll consider that in the future, but for now the today's |
Just tested... IP address sorting works like a charm. |
Merge in DNS/adguard-home from 4143-clients-sort to master Updates #4143. Squashed commit of the following: commit a4b547e Merge: d369c11 d82b290 Author: Ildar Kamalov <ik@adguard.com> Date: Thu Jan 20 11:58:42 2022 +0300 Merge branch 'master' into 4143-clients-sort commit d369c11 Author: Ildar Kamalov <ik@adguard.com> Date: Wed Jan 19 16:53:39 2022 +0300 client: fix sort ip method commit d767a11 Author: Ildar Kamalov <ik@adguard.com> Date: Wed Jan 19 16:23:23 2022 +0300 client: sort client ids
Merge in DNS/adguard-home from 4143-clients-sort to master Updates AdguardTeam#4143. Squashed commit of the following: commit a4b547e Merge: d369c11 d82b290 Author: Ildar Kamalov <ik@adguard.com> Date: Thu Jan 20 11:58:42 2022 +0300 Merge branch 'master' into 4143-clients-sort commit d369c11 Author: Ildar Kamalov <ik@adguard.com> Date: Wed Jan 19 16:53:39 2022 +0300 client: fix sort ip method commit d767a11 Author: Ildar Kamalov <ik@adguard.com> Date: Wed Jan 19 16:23:23 2022 +0300 client: sort client ids
Client Settings Page.
Clicking on column headers sorts the columns.
Assume the clients are defined by their IP addresses like
Sorting on the Client column should sort it like the above (i.e. mathematically incrementing ).. however, the sorting is actually done as if the data was text
Could this small GUI improvement be included in the next build please?
The text was updated successfully, but these errors were encountered: